Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reserve memory in advance and move object instead of copying #3091

Merged
merged 2 commits into from
Apr 9, 2024
Merged

refactor: Reserve memory in advance and move object instead of copying #3091

merged 2 commits into from
Apr 9, 2024

Conversation

CarloVarni
Copy link
Collaborator

as the title says.

Most likely the second is not an issue since it's just a proxy ... but still it does not hurt

@CarloVarni CarloVarni added this to the next milestone Apr 9, 2024
@CarloVarni CarloVarni requested a review from andiwand April 9, 2024 13:38
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

📊: Physics performance monitoring for d54920e

Full contents

physmon summary

@kodiakhq kodiakhq bot merged commit 545f6b7 into acts-project:main Apr 9, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label Apr 9, 2024
@CarloVarni CarloVarni deleted the ReseverMemoryForTracks branch April 9, 2024 21:07
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [545f6b7]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsConversionWorkflow
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
@CarloVarni @Ragansu
refactor: Reserve memory in advance and move object instead of copying (
70aeaa3 
acts-project#3091)

as the title says. 

Most likely the second is not an issue since it's just a proxy ... but still it does not hurt
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@CarloVarni @EleniXoch
refactor: Reserve memory in advance and move object instead of copying (
8229847 
acts-project#3091)

as the title says. 

Most likely the second is not an issue since it's just a proxy ... but still it does not hurt
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@CarloVarni @asalzburger
refactor: Reserve memory in advance and move object instead of copying (
bf262cf 
acts-project#3091)

as the title says. 

Most likely the second is not an issue since it's just a proxy ... but still it does not hurt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Track Finding
Projects
None yet
Milestone
v34.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CarloVarni @acts-project-service @andiwand